Fix race conditions, NPEs and command logic in ItemManager #1
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactored ItemManagerCommand to be stateless by removing instance fields and passing sender/args as parameters. Added argument length checks and type checks (instanceof Player) to prevent exceptions. Renamed 'give' command to 'get' to match help text and intended behavior. Added null check in ItemSort.getItem to prevent NPE.
PR created automatically by Jules for task 10680733511993001918 started by @acsoto